Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional maintainers for the project. #31

Closed
ericcornelissen opened this issue Jun 9, 2021 · 12 comments
Closed

Additional maintainers for the project. #31

ericcornelissen opened this issue Jun 9, 2021 · 12 comments

Comments

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jun 9, 2021

Original below

Per this comment, I'd be looking for new maintainers. While I will try to keep up maintenance for a bit, my intention is to stop maintenance of this project since I'm not using it in any capacity anymore and am too unfamiliar with the code base to make/review major changes.

Since I'm not the owner of this project, I'll defer any decisions about it's future direction in terms of maintenance to @birjj.


Original comment

As noted in this comment and this comment the current maintainer of this project is currently too busy to maintain this project fully. I already offered to help earlier but I guess this comment was missed because that PR was ignored, hence this issue.

I think it would be nice to have at least one more maintainer for this project that can review Pull Requests and get out patches. In particular now that the NPM package has a transitive dependency with a known vulnerability. Again I, and I think other members of the simple-icons project, would be happy to help out given our reliance on this tool - but of course I would encourage others that want to help out to volunteer as well 🙂

@birjj
Copy link
Contributor

birjj commented Jun 10, 2021

Sorry, I completely missed that comment! I've taken to ignoring any notifications for dependabot PRs since I don't have time to release anything, so the message got caught in that.

I'd be happy to add another maintainer if anyone's interested in volunteering. I obviously trust you given previous experience, so I'd be glad to add you if you're up for it @ericcornelissen.

@ericcornelissen
Copy link
Contributor Author

I went ahead and did a review of all open Pull Requests for dependencies and created an extra one for another vulnerability in a dependency. If you find the time you should be able to merge them - or at least the ones that are important, as per my comments - and trigger a new release. If not, you can add me as a collaborator to this project if you want, then I can do it. I'll also try to start looking into the open issues in the coming days as well.


Quick side note on other dependencies with a vulnerability: The transitive vulnerable dependency trim-newlines requires upgrading meow to 10.0.1 but it seems that version is only published as an ES module making it incompatible with the current code base (not to mention it's 7 major versions ahead of the current meow dependency). This will either have to wait for the TypeScript rewrite or at least a rewrite of bin/cli.js to allow it to import ES modules (other modules in this project don't need to be rewritten as ES Modules can import CommonJS modules).

@birjj
Copy link
Contributor

birjj commented Jun 12, 2021

I'll be closing this since I've invited @ericcornelissen as a maintainer. Thanks a lot for helping out!

I've opened #34 to discuss the meow dependency.

@birjj birjj closed this as completed Jun 12, 2021
@ericcornelissen
Copy link
Contributor Author

Re-opening this as I'd be looking for a new maintainer to take over my role. \cc @birjj

@ericcornelissen ericcornelissen pinned this issue Oct 27, 2023
@birjj
Copy link
Contributor

birjj commented Apr 7, 2024

Sorry for the late response.

My life has changed enough that I don't feel I'm in a good place to act as maintainer of an OSS project. The work you've done (both here and in Simple Icons) is incredibly appreciated - without it, the project would've likely been archived.

It looks like the Simple Icons team are the primary contributors currently. Would you be interested in transferring the repo to the Simple Icons organization to formalize that?

@birjj
Copy link
Contributor

birjj commented Apr 8, 2024

Pinging current Simple Icons members (@mondeja, @PeterShaggyNoble, @LitoMore). Is there interest in the organization taking over the svglint project?

@mondeja
Copy link
Member

mondeja commented Apr 8, 2024

I personally agree. Seems that simple-icons is the main consumer of the library.

@LitoMore
Copy link
Member

LitoMore commented Apr 8, 2024

My pleasure.

@birjj
Copy link
Contributor

birjj commented Apr 8, 2024

Nice! It'll be great for the project to find an organizational home, so it doesn't risk being left for dead.
There are two permission things to iron out in the process:

  1. It looks like I need "permission to create public repositories on simple-icons" to transfer the project. Presumably the only way to do this is for me to temporarily join the simple-icons organization? An alternative would be to transfer it to an existing member of simple-icons, who could then transfer it to the organization.
  2. For the NPM package, we'll need to decide on a maintainer from the Simple Icons team to add - preferably one that's already listed as a maintainer on the simple-icons NPM package itself, to avoid any trickery.

@mondeja
Copy link
Member

mondeja commented Apr 12, 2024

Okay, I've invited you temporarily as a maintainer of simple-icons, @birjj. Let me know if you still have no rights to transfer the repo.

@birjj
Copy link
Contributor

birjj commented Apr 12, 2024

I've transferred the svglint repo, and left the organization again. Thanks @mondeja! 🎉

As for the NPM package, I've invite you (~mondeja on NPM) as a maintainer. Once accepted, that should complete the transfer to the simple-icons team.

@mondeja
Copy link
Member

mondeja commented Apr 12, 2024

Great, I've accepted the invitation. Thanks for your hard work until now with this awesome tool. If you want to return to the organization in the future, do not hesitate to contact us. Cheers!

@adamrusted adamrusted unpinned this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants