Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Coverage report generated" is being written to the stdout stream #1060

Open
nevinera opened this issue Jun 1, 2023 · 0 comments
Open

"Coverage report generated" is being written to the stdout stream #1060

nevinera opened this issue Jun 1, 2023 · 0 comments

Comments

@nevinera
Copy link

nevinera commented Jun 1, 2023

Hello! We're writing a tool that runs other tools, rspec among them. One of the problems we've been running into though, is that a ton of people use simplecov already, and when you run rspec -f json, simplecov still writes its "Coverage report generated" message to stdout in plaintext to the same stream.

This seems to be the intent, based on some feature specs I see (like this one), but is there any particular reason to write this to stdout instead of stderr? This seems more like progress/outcome logging than results data (though I recognize the awkwardness of exposing any kind of results when you're essentially a hitchhiker on somebody else's process).

This is somewhat related to #992, though any solution to that (and the workaround described) would need to be invoked by the project intentionally (and so probably wouldn't suffice for our particular intentions).

I'd be happy to contribute a pull-request for this, if you think it's a viable/allowable change to make. Though I might need a pointer, since I'm having trouble figuring out where that text is actually coming from in the gem source :-)

Edit: Found it, it's happening in simplecov-html's HTMLFormatter apparently. No releases there since 2020 - should I bother with a pair of PRs for this?

(I'm using Simplecov 0.22.0 to produce the observed behavior, but I've seen it in a number of prior versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant