Skip to content

Commit 73822ad

Browse files
Adam GoughAdam Gough
authored andcommitted
fix: bun run lint (#557)
1 parent 978a9ea commit 73822ad

File tree

2 files changed

+46
-47
lines changed

2 files changed

+46
-47
lines changed

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx

Lines changed: 39 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import { Button } from '@/components/ui/button'
1717
import { Checkbox } from '@/components/ui/checkbox'
1818
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'
1919
import { createLogger } from '@/lib/logs/console-logger'
20-
import { useDebounce } from '@/hooks/use-debounce'
2120
import { ActionBar } from '@/app/workspace/[workspaceId]/knowledge/[id]/components/action-bar/action-bar'
21+
import { useDebounce } from '@/hooks/use-debounce'
2222
import { useDocumentChunks } from '@/hooks/use-knowledge'
2323
import { type ChunkData, type DocumentData, useKnowledgeStore } from '@/stores/knowledge/store'
2424
import { useSidebarStore } from '@/stores/sidebar/store'
@@ -63,30 +63,33 @@ export function Document({
6363
const isSidebarCollapsed =
6464
mode === 'expanded' ? !isExpanded : mode === 'collapsed' || mode === 'hover'
6565

66-
const currentPageFromURL = parseInt(searchParams.get('page') || '1', 10)
66+
const currentPageFromURL = Number.parseInt(searchParams.get('page') || '1', 10)
6767
const searchQueryFromURL = searchParams.get('search') || ''
6868

6969
const [searchQuery, setSearchQuery] = useState(searchQueryFromURL)
7070

7171
const debouncedSearchQuery = useDebounce(searchQuery, 800)
7272

73-
const updateURL = useCallback((newSearch: string, newPage: number = 1) => {
74-
const params = new URLSearchParams(searchParams)
75-
76-
if (newSearch) {
77-
params.set('search', newSearch)
78-
} else {
79-
params.delete('search')
80-
}
81-
82-
if (newPage > 1) {
83-
params.set('page', newPage.toString())
84-
} else {
85-
params.delete('page')
86-
}
87-
88-
router.replace(`?${params.toString()}`, { scroll: false })
89-
}, [router, searchParams])
73+
const updateURL = useCallback(
74+
(newSearch: string, newPage = 1) => {
75+
const params = new URLSearchParams(searchParams)
76+
77+
if (newSearch) {
78+
params.set('search', newSearch)
79+
} else {
80+
params.delete('search')
81+
}
82+
83+
if (newPage > 1) {
84+
params.set('page', newPage.toString())
85+
} else {
86+
params.delete('page')
87+
}
88+
89+
router.replace(`?${params.toString()}`, { scroll: false })
90+
},
91+
[router, searchParams]
92+
)
9093

9194
const [selectedChunks, setSelectedChunks] = useState<Set<string>>(new Set())
9295
const [selectedChunk, setSelectedChunk] = useState<ChunkData | null>(null)
@@ -121,7 +124,7 @@ export function Document({
121124

122125
useEffect(() => {
123126
if (!knowledgeBaseId || !documentId) return
124-
127+
125128
if (debouncedSearchQuery !== searchQueryFromURL) {
126129
if (debouncedSearchQuery.trim().length >= 2) {
127130
// Starting a search - go to page 1
@@ -131,7 +134,14 @@ export function Document({
131134
updateURL(debouncedSearchQuery, pageBeforeSearch)
132135
}
133136
}
134-
}, [debouncedSearchQuery, searchQueryFromURL, updateURL, knowledgeBaseId, documentId, pageBeforeSearch])
137+
}, [
138+
debouncedSearchQuery,
139+
searchQueryFromURL,
140+
updateURL,
141+
knowledgeBaseId,
142+
documentId,
143+
pageBeforeSearch,
144+
])
135145

136146
useEffect(() => {
137147
setSearchQuery(searchQueryFromURL)
@@ -140,7 +150,7 @@ export function Document({
140150
// Track when search starts to save current page
141151
useEffect(() => {
142152
const isStartingSearch = !searchQueryFromURL && searchQuery.trim()
143-
153+
144154
if (isStartingSearch) {
145155
// User just started typing, save current page
146156
setPageBeforeSearch(currentPageFromURL)
@@ -159,9 +169,12 @@ export function Document({
159169
}
160170
}, [hasNextPage, updateURL, searchQuery, currentPageFromURL])
161171

162-
const handleGoToPage = useCallback((page: number) => {
163-
updateURL(searchQuery, page)
164-
}, [updateURL, searchQuery])
172+
const handleGoToPage = useCallback(
173+
(page: number) => {
174+
updateURL(searchQuery, page)
175+
},
176+
[updateURL, searchQuery]
177+
)
165178

166179
useEffect(() => {
167180
const fetchDocument = async () => {
@@ -840,4 +853,4 @@ export function Document({
840853
/>
841854
</div>
842855
)
843-
}
856+
}

apps/sim/hooks/use-knowledge.ts

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,10 @@ export function useKnowledgeBasesList() {
216216
* Hook to manage chunks for a specific document
217217
*/
218218
export function useDocumentChunks(
219-
knowledgeBaseId: string,
219+
knowledgeBaseId: string,
220220
documentId: string,
221-
urlPage: number = 1,
222-
urlSearch: string = ''
221+
urlPage = 1,
222+
urlSearch = ''
223223
) {
224224
const { getChunks, refreshChunks, updateChunk, getCachedChunks, clearChunks, isChunksLoading } =
225225
useKnowledgeStore()
@@ -258,7 +258,7 @@ export function useDocumentChunks(
258258
// Check cache first
259259
const cached = getCachedChunks(documentId)
260260
const expectedOffset = (currentPage - 1) * 50 // Use hardcoded limit
261-
261+
262262
if (
263263
cached &&
264264
cached.searchQuery === searchQuery &&
@@ -313,22 +313,15 @@ export function useDocumentChunks(
313313
return () => {
314314
isMounted = false
315315
}
316-
}, [
317-
knowledgeBaseId,
318-
documentId,
319-
currentPage,
320-
searchQuery,
321-
isStoreLoading,
322-
initialLoadDone,
323-
])
316+
}, [knowledgeBaseId, documentId, currentPage, searchQuery, isStoreLoading, initialLoadDone])
324317

325318
// Separate effect to sync with store state changes (no API calls)
326319
useEffect(() => {
327320
if (!documentId || !initialLoadDone) return
328321

329322
const cached = getCachedChunks(documentId)
330323
const expectedOffset = (currentPage - 1) * 50
331-
324+
332325
if (
333326
cached &&
334327
cached.searchQuery === searchQuery &&
@@ -342,14 +335,7 @@ export function useDocumentChunks(
342335
if (!isStoreLoading && isLoading) {
343336
setIsLoading(false)
344337
}
345-
}, [
346-
documentId,
347-
isStoreLoading,
348-
isLoading,
349-
initialLoadDone,
350-
searchQuery,
351-
currentPage,
352-
])
338+
}, [documentId, isStoreLoading, isLoading, initialLoadDone, searchQuery, currentPage])
353339

354340
const goToPage = async (page: number) => {
355341
if (page < 1 || page > totalPages || page === currentPage) return

0 commit comments

Comments
 (0)