Skip to content

Commit e324211

Browse files
Adam GoughAdam Gough
authored andcommitted
remove extraneous comments
1 parent e342b31 commit e324211

File tree

7 files changed

+4
-16
lines changed

7 files changed

+4
-16
lines changed

apps/sim/lib/webhooks/processor.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ function resolveEnvVars(value: string, envVars: Record<string, string>): string
195195
const envKey = match.slice(2, -2).trim()
196196
const envValue = envVars[envKey]
197197
if (envValue !== undefined) {
198-
// Use replaceAll to handle multiple occurrences of same variable
199198
resolvedValue = resolvedValue.replaceAll(match, envValue)
200199
}
201200
}
@@ -217,7 +216,6 @@ function resolveProviderConfigEnvVars(
217216
if (typeof value === 'string') {
218217
resolved[key] = resolveEnvVars(value, envVars)
219218
} else {
220-
// Pass through non-string values unchanged (booleans, numbers, objects, arrays)
221219
resolved[key] = value
222220
}
223221
}

apps/sim/lib/workflows/executor/execution-core.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,6 @@ export async function executeWorkflowCore(
158158
})
159159

160160
// Process block states with env var substitution
161-
// This resolves {{VARIABLE}} references in block subBlock values
162-
//
163-
// NOTE: This is DIFFERENT from webhook providerConfig resolution:
164-
// - THIS: Resolves during execution (async, background job)
165-
// - WEBHOOKS: Resolve before queueing (sync, in API route for signature verification)
166-
//
167-
// Why the difference?
168-
// - Block subBlocks are stored in workflow state, resolved at execution time
169-
// - Webhook providerConfig is in DB webhook record, needs sync resolution for auth
170161
const currentBlockStates = await Object.entries(mergedStates).reduce(
171162
async (accPromise, [id, block]) => {
172163
const acc = await accPromise

apps/sim/tools/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ async function handleInternalRequest(
472472
// For custom tools, validate parameters on the client side before sending
473473
if (toolId.startsWith('custom_') && tool.request.body) {
474474
const requestBody = tool.request.body(params)
475-
if (typeof requestBody === 'object' && requestBody !== null) {
475+
if (requestBody.schema && requestBody.params) {
476476
try {
477477
validateClientSideParams(requestBody.params, requestBody.schema)
478478
} catch (validationError) {

apps/sim/tools/twilio_voice/get_recording.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createLogger } from '@/lib/logs/console/logger'
22
import type { TwilioGetRecordingOutput, TwilioGetRecordingParams } from '@/tools/twilio_voice/types'
33
import type { ToolConfig } from '@/tools/types'
44

5-
const logger = createLogger('Twilio Voice Get Recording Tool')
5+
const logger = createLogger('TwilioVoiceGetRecordingTool')
66

77
export const getRecordingTool: ToolConfig<TwilioGetRecordingParams, TwilioGetRecordingOutput> = {
88
id: 'twilio_voice_get_recording',

apps/sim/tools/twilio_voice/list_calls.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createLogger } from '@/lib/logs/console/logger'
22
import type { TwilioListCallsOutput, TwilioListCallsParams } from '@/tools/twilio_voice/types'
33
import type { ToolConfig } from '@/tools/types'
44

5-
const logger = createLogger('Twilio Voice List Calls Tool')
5+
const logger = createLogger('TwilioVoiceListCallsTool')
66

77
export const listCallsTool: ToolConfig<TwilioListCallsParams, TwilioListCallsOutput> = {
88
id: 'twilio_voice_list_calls',

apps/sim/tools/twilio_voice/make_call.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { convertSquareBracketsToTwiML } from '@/lib/webhooks/utils'
33
import type { TwilioCallOutput, TwilioMakeCallParams } from '@/tools/twilio_voice/types'
44
import type { ToolConfig } from '@/tools/types'
55

6-
const logger = createLogger('Twilio Voice Make Call Tool')
6+
const logger = createLogger('TwilioVoiceMakeCallTool')
77

88
export const makeCallTool: ToolConfig<TwilioMakeCallParams, TwilioCallOutput> = {
99
id: 'twilio_voice_make_call',

apps/sim/tools/twilio_voice/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import type { ToolResponse } from '@/tools/types'
22

3-
// Voice Call Types
43
export interface TwilioMakeCallParams {
54
to: string
65
from: string

0 commit comments

Comments
 (0)