feat(helm): added cert-postgresql template to helm#1620
Merged
waleedlatif1 merged 2 commits intostagingfrom Oct 13, 2025
Merged
feat(helm): added cert-postgresql template to helm#1620waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Added cert-manager integration for PostgreSQL TLS certificate management, enabling automated certificate provisioning and renewal for secure database connections.
- Created
certificate-postgresql.yamltemplate that generates a cert-manager Certificate resource when PostgreSQL TLS is enabled - Extended
values.yamlwith comprehensive certificate configuration options including duration (10 years default), renewal period (90 days before expiry), key algorithm (RSA 4096-bit default), and issuer reference - Certificate automatically configures appropriate DNS names for the PostgreSQL service (
<fullname>-postgresqland FQDN within cluster) - Includes support for additional DNS names, rotation policy, and custom issuer groups
- Properly gated behind
postgresql.enabledandpostgresql.tls.enabledflags - Well-documented with inline comments explaining all configuration options
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The implementation follows Helm and cert-manager best practices with proper conditional rendering, sensible defaults, comprehensive documentation, and correct integration with existing PostgreSQL StatefulSet configuration. The certificate configuration aligns with the existing TLS setup in the StatefulSet template
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| helm/sim/templates/certificate-postgresql.yaml | 5/5 | Added cert-manager Certificate resource for PostgreSQL TLS with proper configuration for DNS names, issuer reference, and certificate lifecycle management |
| helm/sim/values.yaml | 5/5 | Extended PostgreSQL TLS configuration with certificate lifecycle settings, issuer reference, and key algorithm options with sensible defaults |
Sequence Diagram
sequenceDiagram
participant User as User/Helm
participant Helm as Helm Chart
participant K8s as Kubernetes API
participant CertMgr as cert-manager
participant Issuer as ClusterIssuer/Issuer
participant PG as PostgreSQL Pod
User->>Helm: helm install with postgresql.tls.enabled=true
Helm->>K8s: Create Certificate resource
Note over Helm,K8s: From certificate-postgresql.yaml
K8s->>CertMgr: Notify new Certificate
CertMgr->>Issuer: Request certificate issuance
Note over CertMgr,Issuer: Using configured issuerRef
Issuer-->>CertMgr: Return signed certificate
CertMgr->>K8s: Store certificate in K8s
Note over CertMgr,K8s: Creates certificatesSecret
Helm->>K8s: Deploy PostgreSQL StatefulSet
K8s->>PG: Mount certificate volume
Note over PG: Mounts at /etc/postgresql/tls
PG->>PG: Enable SSL with certificates
PG-->>K8s: PostgreSQL ready with TLS
Note over CertMgr: 90 days before expiry
CertMgr->>Issuer: Request renewal
Issuer-->>CertMgr: Return renewed certificate
CertMgr->>K8s: Update certificate storage
K8s->>PG: Trigger pod restart
PG->>PG: Load new certificate
2 files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
added cert-postgresql template to helm
Type of Change
Testing
Tested manually
Checklist