Greptile Overview

Greptile Summary

Fixes trigger webhook persistence and collaborative editing synchronization. The PR introduces webhook deletion rollback for Gmail/Outlook configuration failures and adds collaborative state sync after successful saves.

Key Changes

• Webhook rollback: API now deletes webhook records from DB if Gmail/Outlook polling configuration fails, preventing orphaned records
• Collaborative sync: Trigger save now broadcasts webhook state to collaborators using collaborativeSetSubblockValue()
• State management refactor: Replaces computed useMemo with subscribed Zustand selectors for better reactivity
• Code cleanup: Extracts resolveEffectiveTriggerId() helper and removes unused isMounted tracking

Issues Found

• Critical bug in trigger-save.tsx:231-234: Throwing error when saveConfig() returns false will skip collaborative state updates on lines 239-247, causing state desync between local store and collaborators when the API successfully rolls back a failed webhook

Confidence Score: 2/5

• Critical bug in error handling will cause state desync in collaborative environments
• The webhook rollback logic is solid, but throwing on saveConfig() failure skips the collaborative state sync that should propagate the deletion to other users. This creates a race condition where collaborators see stale webhook IDs while the DB has been rolled back.
• trigger-save.tsx lines 231-234 must be fixed before merging - the error handling logic will cause collaborative state desync

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant User
    participant TriggerSave
    participant WebhookHook
    participant API
    participant DB
    participant Collaborative

    User->>TriggerSave: Click Save
    TriggerSave->>TriggerSave: Aggregate config from subblocks
    TriggerSave->>TriggerSave: Validate required fields
    TriggerSave->>WebhookHook: saveConfig()
    
    alt Create New Webhook
        WebhookHook->>API: POST /api/webhooks
        API->>API: Save webhook to DB
        alt Provider is Gmail/Outlook
            API->>API: configureGmailPolling() or configureOutlookPolling()
            alt Configuration Fails
                API->>DB: DELETE webhook (rollback)
                API-->>WebhookHook: Error response
                WebhookHook-->>TriggerSave: false
                TriggerSave->>TriggerSave: Throw error (BUG: skips state sync)
            end
        end
        API-->>WebhookHook: Success with webhook ID
        WebhookHook->>WebhookHook: Update local state
        WebhookHook-->>TriggerSave: true
    else Update Existing Webhook
        WebhookHook->>API: PATCH /api/webhooks/{id}
        API-->>WebhookHook: Success
        WebhookHook-->>TriggerSave: true
    end
    
    TriggerSave->>TriggerSave: Read saved values from store
    TriggerSave->>Collaborative: collaborativeSetSubblockValue() x4
    Collaborative->>Collaborative: Sync to other users
    TriggerSave->>User: Show success message

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}