fix(ui): fixed trigger save, schedule save, time inp, text subblocks and schedule/workflow badges, can now deploy from the badge itself#1868
Merged
waleedlatif1 merged 1 commit intostagingfrom Nov 10, 2025
Conversation
…and schedule/workflow badges, can now deploy from the badge itself
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR implements UI improvements and fixes across workflow block components:
- UI Polish: Removed icons from save/delete buttons, simplified button text, and improved visual consistency across trigger and schedule components
- Badge Interactions: Added click-to-deploy functionality on undeployed workflow badges and click-to-toggle on schedule badges
- State Management: Refactored test URL storage in trigger-save to persist in store instead of local state, improving reliability
- Component Updates: Replaced custom input/copy implementations with reusable
ShortInputcomponent, improved time input UX with read-only input trigger
The changes are mostly cosmetic improvements with one new feature (badge-based deployment). The deployment feature uses proper state management and includes loading states to prevent duplicate requests.
Confidence Score: 4/5
- Safe to merge with minor style considerations
- Most changes are cosmetic UI improvements with low risk. The deployment feature is well-implemented with proper state management and guards against race conditions. Minor concerns include hardcoded colors bypassing theme system and incomplete cursor styling on schedule badge.
- Pay attention to text.tsx (hardcoded theme colors) and workflow-block.tsx (new deployment feature behavior)
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/schedule-save/schedule-save.tsx | 4/5 | UI improvements: removed icons from buttons, simplified button text, removed active/disabled status badge toggle, and improved cron expression formatting. Changes are primarily cosmetic. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/trigger-save/trigger-save.tsx | 4/5 | Refactored test URL management to use store instead of local state, replaced manual input/copy with ShortInput component, removed icons from buttons. Improved state persistence. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx | 3/5 | Added deployment functionality to workflow badges - clicking undeployed badge now triggers deployment. Schedule badge now has similar toggle behavior. Significant new feature with potential edge cases. |
Sequence Diagram
sequenceDiagram
participant User
participant WorkflowBlock
participant DeployAPI as /api/workflows/{id}/deploy
participant WorkflowRegistry
participant useChildDeployment
User->>WorkflowBlock: Click undeployed badge
WorkflowBlock->>WorkflowBlock: Check if isDeploying
WorkflowBlock->>DeployAPI: POST deploy request
DeployAPI-->>WorkflowBlock: Return deployment data
WorkflowBlock->>WorkflowRegistry: setDeploymentStatus()
WorkflowBlock->>useChildDeployment: refetchDeployment()
useChildDeployment->>useChildDeployment: Increment refetchTrigger
useChildDeployment->>DeployAPI: GET /api/workflows/{id}/deployments
DeployAPI-->>useChildDeployment: Return active versions
useChildDeployment->>useChildDeployment: Update isDeployed state
useChildDeployment-->>WorkflowBlock: Badge updates to "deployed"
7 files reviewed, 3 comments
...flowId]/components/panel-new/components/editor/components/sub-block/components/text/text.tsx
Show resolved
Hide resolved
...flowId]/components/panel-new/components/editor/components/sub-block/components/text/text.tsx
Show resolved
Hide resolved
.../sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx
Show resolved
Hide resolved
waleedlatif1
added a commit
that referenced
this pull request
Nov 12, 2025
…text subblocks and schedule/workflow badges, can now deploy from the badge itself (#1868)
waleedlatif1
added a commit
that referenced
this pull request
Nov 12, 2025
…text subblocks and schedule/workflow badges, can now deploy from the badge itself (#1868)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist