Skip to content

fix(variables): fix variables block json resolution #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sg312 merged 1 commit into from
Nov 15, 2025
Merged

fix(variables): fix variables block json resolution #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions apps/sim/executor/handlers/variables/variables-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,33 +127,22 @@ export class VariablesBlockHandler implements BlockHandler {
}

if (type === 'object' || type === 'array') {
// If value is already an object or array, accept it as-is
// The type hint is for UI purposes and string parsing, not runtime validation
if (typeof value === 'object' && value !== null) {
if (type === 'array' && !Array.isArray(value)) {
throw new Error(
`Invalid array value for variable "${variableName || 'unknown'}": expected an array, got an object`
)
}
if (type === 'object' && Array.isArray(value)) {
throw new Error(
`Invalid object value for variable "${variableName || 'unknown'}": expected an object, got an array`
)
}
return value
}
// If it's a string, try to parse it as JSON
if (typeof value === 'string' && value.trim()) {
try {
const parsed = JSON.parse(value)
if (type === 'array' && !Array.isArray(parsed)) {
throw new Error(
`Invalid array value for variable "${variableName || 'unknown'}": parsed value is not an array`
)
}
if (type === 'object' && (Array.isArray(parsed) || typeof parsed !== 'object')) {
throw new Error(
`Invalid object value for variable "${variableName || 'unknown'}": parsed value is not an object`
)
// Accept any valid JSON object or array
if (typeof parsed === 'object' && parsed !== null) {
return parsed
}
return parsed
throw new Error(
`Invalid JSON for variable "${variableName || 'unknown'}": parsed value is not an object or array`
)
} catch (error: any) {
throw new Error(
`Invalid JSON for variable "${variableName || 'unknown'}": ${error.message}`
Expand Down