improvement(rce): updated rce to use isolate pkg for RCE#2385
Merged
waleedlatif1 merged 3 commits intostagingfrom Dec 15, 2025
Merged
improvement(rce): updated rce to use isolate pkg for RCE#2385waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR replaces the Node.js Key Changes:
Security Improvements:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Client
participant Route as POST /api/function/execute
participant IsolatedVM as executeInIsolatedVM
participant Isolate as V8 Isolate
participant SecureFetch as secureFetch
Client->>Route: POST { code, params, envVars, ... }
Route->>Route: Resolve variables in code
Route->>IsolatedVM: Execute code request
IsolatedVM->>Isolate: Create V8 Isolate (128MB limit)
IsolatedVM->>Isolate: Create context
IsolatedVM->>Isolate: Set up globals (params, envVars, console)
IsolatedVM->>Isolate: Set up __fetchRef callback
IsolatedVM->>Isolate: Run bootstrap (console, fetch, block globals)
IsolatedVM->>Isolate: Compile and run user code
alt User code calls fetch
Isolate->>SecureFetch: __fetchRef.apply(url, options)
SecureFetch->>SecureFetch: validateProxyUrl (SSRF check)
SecureFetch-->>Isolate: JSON response
end
alt Success
Isolate-->>IsolatedVM: JSON result
IsolatedVM-->>Route: { result, stdout }
Route-->>Client: 200 { success: true, output }
else Error
Isolate-->>IsolatedVM: Error info
IsolatedVM-->>Route: { error, stdout }
Route->>Route: Format enhanced error
Route-->>Client: 500 { success: false, error }
end
IsolatedVM->>Isolate: dispose()
|
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist