The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Dec 20, 2025 1:38am

Greptile Summary

This PR fixes a critical bug where execution costs were not captured when logs failed to write to the database due to size constraints. The implementation adds three key improvements:

• Enhanced filterForDisplay to truncate strings to 100K characters and remove null bytes that PostgreSQL JSONB doesn't support
• Added completeWithCostOnlyLog fallback mechanism that stores execution costs with empty trace spans when the full log write fails
• Added optional level parameter override to support the fallback scenario

Key Issue Found:

• The fallback mechanism in completeWithCostOnlyLog calls calculateCostSummary(params.traceSpans) on potentially oversized trace spans that caused the original failure. If these spans are large enough to cause memory issues during traversal, the fallback itself will fail and costs won't be captured.

Recommendation:

• Wrap the calculateCostSummary call in a try-catch block that falls back to BASE_EXECUTION_CHARGE if cost calculation fails

Confidence Score: 3/5

• This PR is generally safe but has a potential edge case where the fallback mechanism could fail
• Score reflects good intent and mostly solid implementation, but the fallback in completeWithCostOnlyLog could fail if calculateCostSummary() crashes while traversing oversized trace spans. The display filters are well-implemented with null byte removal and truncation.
• apps/sim/lib/logs/execution/logging-session.ts needs attention - the cost calculation fallback should handle the case where trace spans are too large to traverse

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant WE as Workflow Executor
    participant LS as LoggingSession
    participant EL as ExecutionLogger
    participant DF as DisplayFilters
    participant DB as Database

    WE->>LS: safeComplete(traceSpans)
    LS->>LS: complete(traceSpans)
    LS->>EL: completeWorkflowExecution(traceSpans)
    EL->>DF: filterForDisplay(traceSpans)
    Note over DF: Truncate strings to 100K<br/>Remove null bytes<br/>Handle circular refs
    DF-->>EL: filtered traceSpans
    EL->>DB: Store execution log
    
    alt Database write fails (too large)
        DB-->>EL: Error
        EL-->>LS: Error
        LS->>LS: completeWithCostOnlyLog()
        LS->>LS: calculateCostSummary(traceSpans)
        Note over LS: Extract costs from<br/>oversized traceSpans
        LS->>EL: completeWorkflowExecution(empty traceSpans)
        Note over LS: Pass empty array to avoid<br/>size issues
        EL->>DF: filterForDisplay([])
        DF-->>EL: []
        EL->>DB: Store cost-only log
        DB-->>EL: Success
        Note over DB: Cost captured,<br/>traceSpans empty
    end

@greptile