improvement(block-inputs): must parse json accurately + models max_tokens fix#3033
Merged
icecrasher321 merged 7 commits intostagingfrom Jan 28, 2026
Merged
improvement(block-inputs): must parse json accurately + models max_tokens fix#3033icecrasher321 merged 7 commits intostagingfrom
icecrasher321 merged 7 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR improves type safety and log display by correctly handling JSON inputs across 24 block integrations and the block executor. Key Changes:
Impact:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant BlockExecutor
participant VariableResolver
participant parseJsonInputs
participant BlockLog
participant onBlockComplete
User->>BlockExecutor: Execute block with inputs
BlockExecutor->>VariableResolver: resolveInputs(ctx, params)
VariableResolver-->>BlockExecutor: resolvedInputs (strings)
alt Block logging enabled
BlockExecutor->>parseJsonInputs: parseJsonInputs(resolvedInputs)
parseJsonInputs->>parseJsonInputs: Check each value with isJSONString()
parseJsonInputs->>parseJsonInputs: JSON.parse() on JSON-like strings
parseJsonInputs-->>BlockExecutor: parsed inputs (objects/arrays)
BlockExecutor->>BlockLog: Set blockLog.input with parsed data
end
BlockExecutor->>BlockExecutor: Execute block operation
alt Success path
BlockExecutor->>parseJsonInputs: parseJsonInputs(resolvedInputs)
parseJsonInputs-->>BlockExecutor: parsed inputs
BlockExecutor->>onBlockComplete: callback(ctx, node, block, parsed inputs, output)
else Error path
BlockExecutor->>parseJsonInputs: parseJsonInputs(input)
parseJsonInputs-->>BlockExecutor: parsed inputs
BlockExecutor->>BlockLog: Set blockLog.input with parsed data
BlockExecutor->>onBlockComplete: callback(ctx, node, block, parsed inputs, errorOutput)
end
|
Collaborator
Author
|
@cursor review |
Collaborator
Author
|
@cursor review |
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist