-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron forge #432
Comments
I like the idea of making it easier to get started, but I'm not sold on this approach. The tool seems to be very immature, so it's too early to judge it too much. It will definitely conflict with framework specific CLIs. It's also IMHO too opinionated. There is already a great solution for easily building Electron apps -> I would just use // @develar |
Yes. electron-builder handles a lot of aspects and electron-forge as a tool to build is a far away in terms of quality / feature set. electron-builder will be able to pack electron-compile projects soon (or just use babel, see electron-userland/electron-builder#807). |
I left this issue untouched as I wanted to see what the thoughts were without getting involved too much 👍 That being said, I always want to make
We expose all of our methods/actions as JS API to make it super easy for framework specific CLI's to integrate Electron related tooling into their workflow. For instance
This is definitely something I've become aware of as I built it, and I tried to reduce the opinionated nature of the tool as much as I could. If there are still things where you think I'm forcing people to do X a certain way instead of giving them the option can you let me know? A main point of
I think this is a misunderstanding of project goals, Electron Forge isn't designed for just "building" applications, it's designed to help you create your entire app from the initial template, through the development phase all the way to publishing.
I have had discussions with @develar about
I feel I should point out we haven't reinvented the wheel. Electron Forge is the bare minimum "wiring" between numerous community modules that people have been using for years. All of our make targets aren't written from scratch, they simply call the existing supported modules like
Ouch 😆 People are already using forge seamlessly in a lot of projects including me in my personal projects, I may be biased (we both are) but I think that in terms of quality the tool is up there and the feature set is pretty much everything you would need to make and distribute an Electron application.
The whole point of All this being said, I'm not advocating for this to be put on the list 😆 if I wanted that I would have made a PR, I simply want to explain the points you guys made for future people looking at this issue. A reasonably fair assessment of The TLDR is Worth a read: https://beta.electronforge.io |
This task in progress. But packaging (and publishing, auto-update files) will be still not performed by electron-builder. i.e. when electron-builder targets will be available for electron-forge, way "use |
@develar Yeah, informing the user that As for the publishing, forge allows for custom publish modules as well, so your publishers could technically be exposed in a forge compatible way as well 🤔 Still keen to get this integration going though so the two module seem less like competitors and more like buddies 😆 |
you might add https://github.com/electron-userland/electron-forge
It's the new wizz bang generator...
The text was updated successfully, but these errors were encountered: