-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Add CI to automate heavy PR load #1365
Comments
I honestly think this will just create more work for us with false-positives. It's really hard to correctly lint Markdown and many of the things I comment on cannot be automatically linted. I guess we could experiment with In short, |
How about a complementary approach: encourage the automated generation of awesome lists. To generate an awesome list that conforms to the requirements not much are needed:
A short script in ones favorite language could do the trick. |
@sellisd Awesome lists should be hand-made. We already link to a generator to make it easier to get started: https://github.com/dar5hak/generator-awesome-list |
Yes :) See my first PR for awesome-lint. I've actually worked quite a bit with unist and the remark ecosystem, and I'm excited to work on this. There will still be a need for manual review of submissions, but I really think that just having an obvious RED LIGHT when someone creates a PR request because of failing some basic linting check will make your life easier as a maintainer. Our goal with the linter shouldn't be to catch all false-positives. It should be to make it very clear when submitting that the author hasn't adhered to basic guidelines. As long as the linter can't produce false-negatives (e.g., linter says your readme is invalid, but it's really okay), then I think this will be an overall win for cutting down the time it takes to deal with submissions. |
@transitive-bullshit Good to hear. Let's make this happen then :) |
@sindresorhus @transitive-bullshit Added a PR ( #1675 ) for linting awesome itself with Do share your thoughts. |
This would ideally combine awesome-lint with a linter for the pull requests themselves and the main
awesome
readme.Related to #1363 and the goal of maintaining Sindre's sanity 💯
Here's my proposed game plan:
awesome-lint
that lints this repo'sreadme.md
to verify formatting and extract all the sub-listsawesome-lint
There will be some existing awesome lists that don't pass
awesome-lint
, so we could whitelist these for now and incrementally fix them until the whitelist can be removed.This would also put more onus on the
awesome-lint
project which appears to have been inactive for some time.Possible future extensions:
awesome-lint
in the defaultawesome
list template such that it would be enforced via CI for sub-awesome lists going forwards.@sindresorhus I'd be happy to spearhead this, since I really believe these lists help countless developers out there every day, and the current gameplan of manual reviewing (even with the help of fellow list-makers) seems sub-optimal.
The text was updated successfully, but these errors were encountered: