Add borderBackgroundColor option
#100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jul 16, 2024
👍 |
|
I've made it so that the user can specify 'none' for no color. I'm unsure if it's good or if we should use null instead. |
|
|
||
| Defaults to `backgroundColor`. Use `'none'` for no color. | ||
| */ | ||
| readonly borderBackgroundColor?: Color; |
There was a problem hiding this comment.
Suggested change
| readonly borderBackgroundColor?: Color; | |
| readonly borderBackgroundColor?: Color | undefined; |
This would be better than 'none'.
There was a problem hiding this comment.
That wouldn't work because now there is no way to differentiate between "unspecified" and "explicitly no color". Maybe should we revert this back ?
There was a problem hiding this comment.
But it should not be in the general Color type. Only this property needs it. And what do you think of instead having a 'inherit' case, which it would default to?
So:
{borderBackgroundColor: undefined}=> no color{borderBackgroundColor: 'inherit'}=> inherit color{}=> inherit color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the
borderBackgroundColoroption, following most of @ThornDuke's implementation in #94. I've also added docs, example, test and types.All tests pass except the
xothat throws this error for pre-existing code:I'm not quite sure what triggers it, it might be a new error due to the recent dependency bump (see #97).
Also I'm wondering if we should make
borderBackgroundColordefault tobackgroundColorif unspecified ?