Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class name issues resulting in hide-preferences-window not removed #1983

Closed
dusansimic opened this issue Jan 19, 2023 · 3 comments · Fixed by #2006
Closed

Class name issues resulting in hide-preferences-window not removed #1983

dusansimic opened this issue Jan 19, 2023 · 3 comments · Fixed by #2006

Comments

@dusansimic
Copy link
Collaborator

Some class names in the Messenger website have changed which has resulted in the Caprine code working and not removing the hide-preferences-window class which hides the modals. This causes any modal to be hidden (including preferences, remove chat, votes, change nick, all kinds of menus...).

@efeftimov
Copy link

fixed it by deleting/commenting 92th line of the browser.css (usr/lib/caprine/css on manjaro)

html.hide-preferences-window div[class='x9f619 x1n2onr6 x1ja2u2z'] > div:nth-of-type(3) > div > div {display: none; }

@dusansimic
Copy link
Collaborator Author

@efeftimov that's a workaround at best. The goal of hiding preferences modal is to hide it from the user when some settings need to be applied (they are picked in the menu bar but the preferences modal needs to be opened to actually set them and that is done by programmatically opening it. To hide that process from the user, preferences modal is hidden using the css style you suggest should be removed.).

@melissis
Copy link

melissis commented Sep 12, 2023

This issue seems to be back. On 2.58.1.
I don't know if it's hide-preferences-window or something else that causes it, but things are hidden.

Edit: Now something happened. I can use these functions again. I've had this issue for at least a month but now it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants