prop.get(user, 'name.first') will throw if name is null

[matthewmueller]

Seems weird to me that this library throws on things like: null, false, 3, "hi".

I feel like the obj === undefined check should be isObj(obj) or something.

[stevemao]

Maybe we should check the accessibility of the property?

[sindresorhus]

Yeah, that's a bug. It should never throw no matter what you feed it. That's the whole point of this module.

[stevemao]

@sindresorhus do you want to support situation that a getter might throw? the only way is to try... catch it?

[sindresorhus]

Yes

[stevemao]

I think I know what you are going to say @sindresorhus , you probably just don't want to 'throw' from this module (and don't care too much about the performance) but the reason I try to avoid 'try...catch' and this module to 'throw' was to avoid regression.

Sent from my iPhone

On 16 Nov 2015, at 8:35 PM, Sindre Sorhus notifications@github.com wrote:

Yes

—
Reply to this email directly or view it on GitHub.

[sindresorhus]

and don't care too much about the performance

try/catch doesn't have to mean worse performance. try/catch only deoptimizes the current function. If you put it in a helper function you're good.

[stevemao]

Ok, I'll get my Mac next Monday so seven more days if you guys don't mind waiting :)

[sindresorhus]

I can wait. I don't have time to look into this right now anyways.

[stevemao]

@matthewmueller @sindresorhus please review #12 :)