Rule proposal: require node:assert/strict

[electrovir]

Description

The built-in Node.js node:assert module is considered "legacy" and node:assert/strict is the non-legacy module. See the docs here: https://nodejs.org/api/assert.html#legacy-assertion-mode.

In particular, those docs note that the legacy node:assert module may produce unexpected, rather absurd, results.

Fail

import assert from 'node:assert'

import assert from 'assert'

Pass

import assert from 'node:assert/strict'

import assert from 'assert/strict'

Proposed rule name

prefer-node-assert-strict, prefer-strict-node-assert, prefer-strict-node-assert-module, prefer-strict-node-import

Additional Info

No response

[sindresorhus]

This would probably be better suited for https://github.com/eslint-community/eslint-plugin-n

[electrovir]

Looks like the original eslint-plugin-node repo even has a ticket about it: mysticatea/eslint-plugin-node#218

[electrovir]

While I don't see a strictly followed conceptual split between this plugin and eslint-plugin-n, I can guess where that split would be, and I agree this rule makes sense in there. If you prefer this proposal to be in eslint-plugin-n I can open an issue there.

[sindresorhus]

If you prefer this proposal to be in eslint-plugin-n I can open an issue there.

👍

[electrovir]

For reference, I found some relevant tickets already in eslint-plugin-n:

• Rule ideas eslint-community/eslint-plugin-n#293
• prefer-import/assert-strict: new rule to prefer import 'node:assert/strict' eslint-community/eslint-plugin-n#59