Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.request now receives a timeout option #226

Closed
sotojuan opened this issue Oct 13, 2016 · 4 comments
Closed

http.request now receives a timeout option #226

sotojuan opened this issue Oct 13, 2016 · 4 comments
Labels
future The issue will be worked on in the future

Comments

@sotojuan
Copy link
Contributor

This is new in Node v6.8.0. PR here.

Not sure what the implications for got are but thought I'd let you know!
@kevva
Copy link
Contributor

kevva commented Oct 14, 2016

All tests passes using 6.8.0 so I guess it doesn't have any direct implications.

@sindresorhus
Copy link
Owner

@floatdrop Maybe it could simplify your timed-out module?

@floatdrop floatdrop mentioned this issue Oct 23, 2016
Open
@floatdrop
Copy link
Contributor

@sindresorhus maybe, but it was not backported to 4.x branch. So somewhere in the future.

@floatdrop floatdrop added the future The issue will be worked on in the future label Oct 23, 2016
@floatdrop
Copy link
Contributor

Dups #257 – will be resolved there.

@snyk-bot snyk-bot mentioned this issue Sep 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future The issue will be worked on in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sindresorhus @floatdrop @kevva @sotojuan