Check protocol before sending request #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippe-git
commented
May 3, 2017
| path: '', | ||
| retries: 5 | ||
| }, | ||
| url, | ||
| { | ||
| protocol: url.protocol || 'http:' // Override both null/undefined with default protocol | ||
| }, | ||
| opts | ||
| ); |
There was a problem hiding this comment.
urlParseLax returns null for all properties that weren't parsed, so protocol: null used to take over the default protocol: 'http:' all the time for protocol-less urls; this change remedies that.
sindresorhus
approved these changes
May 5, 2017
floatdrop
approved these changes
May 5, 2017
|
Thanks @pioul :) |
|
👍 @sindresorhus Of course! Just realizing now that there's a bit of doc I haven't updated if you want to quickly add a line there: https://github.com/sindresorhus/got#errors By the way, how often are you releasing? I'd love to take advantage of that addition in a dependent (probe-image-size) once the next release is out :) |
|
Readme updated. I missed it too. Right now we're targeting a new major release in a couple of weeks. |
|
Thanks, sounds great! |
This was referenced May 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294 by making sure an url has a valid protocol (http/https) before sending a request.
Let me know if any other tweak would make sense before merging this PR!