Set up proxy event emitter before making a request #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, every time I run the full test suite
nyc
pesters me with its angry red uncovered L34 (in this PR). I decided to dive in and find out why. The reason is: we emit the protocol error before we've had the chance to attach an error listener. So Node blows up, and indeed we never execute the return statement.Wrapping the first request in a
setImmediate
so the proxy event emitter can get set up makes more sense to me than removing the return statement.Maybe you feel the alternative works better. Your call!EDIT: Spotting our code never hits that return statement or the rest of the function body the statement returns flow to is unlikely. On second thought, I'm strongly for my current approach; the only potential problem is practical issues with altering the code flow this way.