Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron.net decompress caveat #717

Closed
ccorcos opened this issue Jan 31, 2019 · 2 comments
Closed

electron.net decompress caveat #717

ccorcos opened this issue Jan 31, 2019 · 2 comments
Labels
bug Something does not work as it should

Comments

@ccorcos
Copy link

ccorcos commented Jan 31, 2019

  • Node.js version: v11.3.0
  • OS & version: Mac OS 10.14

The decompress: false option doesn't work as expected. When you're using electron's net API, the chromium network stack will automatically send accept-encoding headers and decode the result for you. Thus, the response data will always be decoded regardless of the content-encoding header. It would be nice to add this to the documentation under the decompress option.

@szmarczak
Copy link
Collaborator

Currently lots of electron features are broken, because of the new electron updates. We haven't fixed that yet - currently we are focused on rewriting Got to TypeScript. Once we achieve that, we'll figure out the rest :)

@szmarczak szmarczak added the bug Something does not work as it should label Jan 31, 2019
@sindresorhus sindresorhus changed the title Electron Net decompress Caveat electron.net decompress caveat Feb 1, 2019
@szmarczak szmarczak added this to the v10 milestone Feb 1, 2019
@sindresorhus sindresorhus removed this from the v10 milestone Apr 18, 2019
@szmarczak
Copy link
Collaborator

Closing in favor of #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as it should
Projects
None yet
Development

No branches or pull requests

3 participants