Gzip seems not work in my project

[grapehunter]

What would you like to discuss?

Enviroment:
Running in render process with Electron 7 (But not use Electron.net.)

Code:
got('http://www.example.com', { decompress: true }).then(r => console.log(r.body));

Result:

It looks like the gzip data is not being decoded correctly

Checklist

• I have read the documentation.
• I have removed node_modules and reinstalled all dependencies by yarn install.
• I have removed .yarnclean and reinstalled all dependencies by yarn install.

[szmarczak]

What Got version are you running?

[grapehunter]

What Got version are you running?

The latest release version with yarn add got, I think it is 9.6.0

[grapehunter]

Checked. NOT THIS REASON.

Very weird because I tested with the same code on runkit and the results were correct
Is it possible that the relevant code was cleared by yarn clean?
Here is my .yarnclean

# test directories
__tests__
test
tests
powered-test

# asset directories
docs
doc
website
images
assets

# examples
example
examples

# code coverage directories
coverage
.nyc_output

# build scripts
Makefile
Gulpfile.js
Gruntfile.js

# configs
appveyor.yml
circle.yml
codeship-services.yml
codeship-steps.yml
wercker.yml
.tern-project
.gitattributes
.editorconfig
.*ignore
.eslintrc
.jshintrc
.flowconfig
.documentup.json
.yarn-metadata.json
.travis.yml

# misc
# *.md
*.gz

[grapehunter]

I have found out the reason.
In get-response.js

const decompressResponse = require('decompress-response');

decompressResponse is not a function but a empty object.
decompress-response was disabled in package.json

"browser": {
		"decompress-response": false,
		"electron": false
	}
}

After removing "decompress-response": false,, all is working now

[szmarczak]

Glad you've solved the issue! PR welcome :)

[szmarczak]

It used to work some while ago. Now electron support is broken.

[adityapk00]

Was this fixed? It seems to be broken with electron, and fails with the same error.

[szmarczak]

Electron support has been deprecated, as the electron.netAPI differs very much from the Node js http API.

[ci010]

I have found out the reason.
In get-response.js

const decompressResponse = require('decompress-response');

decompressResponse is not a function but a empty object.
decompress-response was disabled in package.json

"browser": {
		"decompress-response": false,
		"electron": false
	}
}

After removing "decompress-response": false,, all is working now

Notice that the package.json referring here is from got, which means if you want to bundle got with webpack in target electron-renderer. You will need to modify the got package.json in node_modules. I think we should simply remove this field since got is a package for node environment, not the browser.