-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extends #163
Conversation
It should be exposed as |
@sindresorhus If desired, all of the baseConfig options can be hoisted by using ESLint's config schema: https://github.com/sindresorhus/grunt-eslint/compare/master...pro-src:hoist_base_config?expand=1 And maybe fail hard if an unrecognized option is specified. |
I know you have 1k other PRs to like at that are far more interesting but I'm bored so I'm going to bug you anyway. 😜 I'm wondering if you had something else in mind for this PR. As the the issue title is confusing to me. Simply because there is already support for the "extends" option. I get what you mean by it should be exposed as "extends" but it has already been exposed as "extends" by ESLint though nested under the documented Thanks |
Nah, the point is to just make the --
Yes, but it's not discoverable. |
@kevva Thanks for the review. Did you notice https://github.com/sindresorhus/grunt-eslint/compare/master...pro-src:hoist_base_config?expand=1 ? It uses the rest operator 👍 |
Closes #160
https://eslint.org/docs/developer-guide/nodejs-api
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor