Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching parent paths #74

Closed
stefanKuijers opened this issue Nov 21, 2016 · 5 comments · Fixed by #78
Closed

Matching parent paths #74

stefanKuijers opened this issue Nov 21, 2016 · 5 comments · Fixed by #78

Comments

@stefanKuijers
Copy link

Thanks for the handy plugin.

I ran into the following problem while running my gulp task for a different directory than my workin directory:

filter: '**/*.js'
did not match: ..\..\path\to\script.js

To me this really seems to unexpected behavior.
I am aware of this issue.

My question is:
is there any chance to merge in the snippet @cb1kenobi posted? It would be great if I don't have to fork and publish my own package for this.

Thanks in advance

@nfroidure
Copy link
Contributor

I do no see any PR for that, has it been closed?

@stefanKuijers
Copy link
Author

stefanKuijers commented Jan 5, 2017

Sadly I don't really have time currently to create a PR that's why I just added a link to the code which solves it.

First I would like to know or there is any interest. If there is interest I will see when I can make time to create a PR

@cb1kenobi
Copy link
Contributor

@nfroidure @stefanKuijers PR submitted!

@stefanKuijers
Copy link
Author

@cb1kenobi Awesome!

@stefanKuijers
Copy link
Author

@sindresorhus : Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants