Skip to content
This repository was archived by the owner on Jan 23, 2021. It is now read-only.
/ gulp-myth Public archive

gulp-sourcemaps support #7

Closed
demisx opened this issue Nov 29, 2014 · 7 comments
Closed

gulp-sourcemaps support #7

demisx opened this issue Nov 29, 2014 · 7 comments

Comments

@demisx
Copy link

demisx commented Nov 29, 2014

It appears that this plug-in does not support sourcemap generation via gulp-sourcemaps plugin https://github.com/floridoo/gulp-sourcemaps/wiki/Plugins-with-gulp-sourcemaps-support. I think would be beneficial from consistency point of view if it did. What are your thoughts on that?

@sindresorhus
Copy link
Owner

Sure, I don't use this anymore so I haven't prioritized it, but PR welcome ;)

Should be pretty easy as you can pretty much look at how it's done in https://github.com/sindresorhus/gulp-autoprefixer/ and https://github.com/sindresorhus/gulp-autoprefixer/blob/f6498a366b14b33510b82af0efec4e762e7b979d/test.js#L27-L54

@kevva
Copy link

kevva commented Feb 16, 2015

Should we keep the sourcemap option?

@sindresorhus
Copy link
Owner

No

@kevva
Copy link

kevva commented Feb 16, 2015

When setting sourcemapAsObject: true which is needed for vinyl-sourcemaps-apply it just throws Uncaught /home/kevva/Projects/gulp-myth/fixture/fixture.css:1:1: Unclosed block. Suspect this is coming from autoprefixer which is included with myth.

@kevva
Copy link

kevva commented Feb 24, 2015

I've tried using myth as a rework plugin instead and while I get the sourcemap object back it's still incorrect. It's missing the file property and the sources is incorrect (only includes the default name source.css).

@sindresorhus
Copy link
Owner

⬆️ As per suggested here: segmentio/myth#116

@sindresorhus
Copy link
Owner

Closing as this project is deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants