Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis #168

Closed
sindresorhus opened this issue Aug 23, 2019 · 6 comments · Fixed by #177
Closed

Fix Travis #168

sindresorhus opened this issue Aug 23, 2019 · 6 comments · Fixed by #177
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Aug 23, 2019

Issuehunt badges

https://travis-ci.com/sindresorhus/ky/jobs/227726270

Travis is slow. I think we might just need to increase the Puppeteer timeout somehow.


IssueHunt Summary

dirathea dirathea has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sholladay
Copy link
Collaborator

The three most recent Travis builds all failed in exactly the same way, always a TimeoutError and always on Node 10 but not Node 12. Seems kinda fishy, no? Also, it says the timeout is 30 seconds which seems pretty reasonable to me.

@sindresorhus
Copy link
Owner Author

sindresorhus commented Aug 23, 2019

Could be, but from experience, it's almost always Travis being slow, especially when the problem is only on older Node.js versions. Could also be a race issue in the code or test.

@szmarczak
Copy link
Collaborator

Could also be a race issue in the code or test.

It's not definitely a race issue. I've experienced it also when developing http2-wrapper.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 10, 2019

@issuehunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 10, 2019
@koraykoska
Copy link

I will give this a try

@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 1, 2019

@sindresorhus has rewarded $36.00 to @dirathea. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants