Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TimeoutError#cause to be Request or URL #592

Closed
arty-name opened this issue Jun 19, 2024 · 2 comments · Fixed by #595
Closed

Set TimeoutError#cause to be Request or URL #592

arty-name opened this issue Jun 19, 2024 · 2 comments · Fixed by #595

Comments

@arty-name
Copy link
Contributor

TimeoutError now includes the Request as .request property.

JS errors also have a standard property .cause which is widely supported by various tooling. Would it make sense for TimeoutError to set this property in addition to (or even instead of) the .request? The value could be the whole Request or just its URL.

If not added into the core, this could be a use case for beforeTimeout hook.
@arty-name arty-name mentioned this issue Jun 19, 2024
Closed
@arty-name
Copy link
Contributor Author

Actually the whole Request seems to choke my tooling at least (Vite/Astro), so the URL could be a better option.

@sholladay sholladay mentioned this issue Jun 23, 2024
Merged
@arty-name
Copy link
Contributor Author

Thank you everyone for the quick solution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add request method and URL to error messages sholladay/ky
Add cause to TimeoutError
1 participant
@arty-name