-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer local install #572
Prefer local install #572
Conversation
Can you mention the behavior in the readme? That the globally installed CLI uses the local version if any. |
I am wondering about our choice here. If the local project has an outdated version of With AVA and XO, it's not a big deal. |
source/cli.js
Outdated
// Prefer the local installation | ||
if (!importLocal(__filename)) { | ||
if (isInstalledGlobally) { | ||
console.log('Using global install of np.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be logged each time. You can use util.debuglog
.
For example? |
You keep adding new features / checks all the time (like waiting for GitHub Actions to complete, etc). If I have come to rely on some new feature, and open up some old project - I am just wondering if we need the added auto-magic convenience on a module I use 10x-20x less than |
I think it's more important to use the correct |
Oh, totally agree. My point was that maybe we could just enforce it with a failure of the global CLI, instead of automatically running the local one. That way the user is making the conscious choice to use the older local |
Fixes #571