Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.2: program arguments still not being passed to Mac's open program (previously #231) #234

Closed
ericmandel opened this issue Mar 12, 2021 · 0 comments · Fixed by #237
Closed

Comments

@ericmandel
Copy link
Contributor

re: #231

Using the correct calling sequence still does not pass program arguments correctly on a Mac:

[~/tmp] eric% npm ls
tmp@ /Users/eric/tmp
└─┬ open@8.0.2
  ├── define-lazy-prop@2.0.0
  ├── is-docker@2.1.1
  └─┬ is-wsl@2.2.0
    └── is-docker@2.1.1 deduped

[~/tmp] eric% node
Welcome to Node.js v15.11.0.
Type ".help" for more information.

> const open = require('open');
undefined

> open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: ['--incognito']}});
Promise {
  <ref *1> ChildProcess {
    _events: [Object: null prototype] {},
    _eventsCount: 0,
    _maxListeners: undefined,
    _closesNeeded: 3,
    _closesGot: 0,
    connected: false,
    signalCode: null,
    exitCode: null,
    killed: false,
    spawnfile: 'open',
    _handle: Process {
      onexit: [Function (anonymous)],
      pid: 27250,
      [Symbol(owner_symbol)]: [Circular *1]
    },
    spawnargs: [ 'open', '-a', 'google chrome', 'https://sindresorhus.com' ],
    pid: 27250,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant