Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gotOpts #41

Closed
duncanfwalker opened this issue Jan 3, 2018 · 2 comments
Closed

Add gotOpts #41

duncanfwalker opened this issue Jan 3, 2018 · 2 comments

Comments

@duncanfwalker
Copy link

I see that since the proxy request was closed ( #22) proxy support has been added to got.

I would like to be able to pass options through to got so that I can use a tunneling agent over a proxy.

Would you consider a pull request to add this in? If you are I'd be happy to have a go.

@duncanfwalker
Copy link
Author

Hi @sindresorhus - do you think you would be open to a PR for adding those options in? I know it isn't priority for a lot of people but I imagine there are a few people trying to use this in corporate environments

@sindresorhus
Copy link
Owner

Probably not, sorry. My stance is that this should be solved in Node.js, or at the very least in Got (without any options needed). I'm not interested in having options for this in every module that does any kind of HTTP. If I allow this, I'm gonna get requests for this kind of option in every module that depends on package-json, etc etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants