You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function Number.isFinite returns false for all arguments of type bigint. So the formatting function throws immediately. It would be helpful if bigint would be supported as well. I would like to use it with Node's fs.stat, which now can return bigint values for file sizes.
(I tested how the function would behave without the check, and unfortunately the Math functions do not support bigint arguments: Cannot convert a BigInt value to a number at Math.log)
The text was updated successfully, but these errors were encountered:
PR welcome. For the one that wants to work on this, you need to update the readme, the TypeScript definitions, and add tests.
Since official support for BigInts in Node.js comes from v10.4.0 and at the moment support for it is not the best (what about Math functions?), should this be postponed at least until Node 8 goes EOL? (2019-12-31)
If not, should we use something along the lines of big-integer to provide support for them (which anyway doesn't solve the Math.log issue)?
The function
Number.isFinite
returnsfalse
for all arguments of typebigint
. So the formatting function throws immediately. It would be helpful ifbigint
would be supported as well. I would like to use it with Node'sfs.stat
, which now can returnbigint
values for file sizes.(I tested how the function would behave without the check, and unfortunately the
Math
functions do not supportbigint
arguments:Cannot convert a BigInt value to a number
atMath.log
)The text was updated successfully, but these errors were encountered: