Add hotkey to open selected notification in new tab #1240

Maxscores · 2018-04-02T20:04:34Z

Adds feature where a user can use 'shift o' on a highlighted notification to open the notification in a new tab.

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

sindresorhus · 2018-04-03T03:41:15Z

source/features/open-notification-in-new-tab.js

+
+	document.addEventListener('keyup', event => {
+		const notification = select('.js-notification, .navigation-focus');
+		const isO = (event.key === 'O');


This can just be inline in the if statement.

Ha, definitely..

sindresorhus · 2018-04-03T03:41:35Z

source/features/open-notification-in-new-tab.js

+	document.addEventListener('keyup', event => {
+		const notification = select('.js-notification, .navigation-focus');
+		const isO = (event.key === 'O');
+		const url = document.querySelector('.navigation-focus').querySelector('a');


document.querySelector('.navigation-focus').querySelector('a'); => document.querySelector('.navigation-focus a');

Much better, thanks

sindresorhus · 2018-04-03T03:43:16Z

source/features/open-notification-in-new-tab.js

+import {registerShortcut} from './improve-shortcut-help';
+
+export default function () {
+	registerShortcut('notifications', 'shift o', 'Open Notification in New Tab');


Open Notification in New Tab => Open selected notification in new tab?

@sindresorhus is definitely more clear, thanks for taking the time to review!

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

fregante · 2018-04-03T15:23:24Z

GitHub itself seems to have this feature in the code, but I can't seem to enable it. It should work via Ctrl+Enter. Does it work on Windows?

yakov116 · 2018-04-03T15:25:28Z

@bfred-it ~~where should I check?~~ it worked

Maxscores · 2018-04-03T15:42:53Z

@bfred-it 'CTRL + Enter' Doesn't work on my Mac

fregante · 2018-04-03T15:46:16Z

@bfred-it it worked

Windows, I imagine?

So this feature is Mac-specific + should be activated via ctrl enter as well, unless anyone else can replicate on Mac somehow too.

yakov116 · 2018-04-03T15:50:10Z

@bfred-it windows

I am not sure it worked. Where should I be doing it on the notification screen?

fregante · 2018-04-03T15:51:46Z

Where should I be doing it on the notification screen?

On the notification screen, select a notification via j/k and then press ctrl+enter; the notification should open in a new tab. If you just press enter or o it should just open it in the current tab.

Maxscores · 2018-04-03T15:53:53Z

How would I go about adding a listener for 'ctrl - enter'? Is there a way to listen for key combos? From what I'm seeing is that the keyCode is the same when I press enter whether or not I have ctrl pressed.

yakov116 · 2018-04-03T15:55:12Z

@bfred-it I'm slow lol. I forgot it should open in a new tab. Nope it's not working for me

fregante

This can be renamed to be non-notifications-specific. It can work across the site.

Maxscores · 2018-04-03T16:17:15Z

source/features/open-notification-in-new-tab.js

-			window.open(url, '_blank');
+	document.addEventListener('keypress', event => {
+		const selected = document.querySelector('.navigation-focus .js-navigation-open[href]');
+		if (selected && event.key === 'O') {


Nice, that's a much more concise way of doing it

yakov116

you forgot the .js

fregante · 2018-04-03T16:39:18Z

Thanks @yakov116!

Maxscores · 2018-04-05T16:18:38Z

@bfred-it Added description and gif of interaction to the readme

fregante · 2018-04-06T19:00:02Z

@Maxscores thanks for this PR ^_^

vanniktech · 2018-04-24T09:08:03Z

Is it possible to open the new tab but stay in the notifications?

My use case is that I go through all of the notifications, select the ones I want to go deeper into with shift + o and then once they've been cleared I'll switch tabs.

vanniktech · 2018-04-24T09:08:47Z

Another things is that when you press shift + o they're not marked as read immediately. Instead they still appear in the list and only when refreshing they'll be gone.

fregante · 2018-04-24T09:15:31Z

Is it possible to open the new stab but stay in the notifications?

Possible, but you probably shouldn't stab anyone before reading their messages.

Yes, I'd prefer the same. Instead of window.open(selected, '_blank'); it can use this https://github.com/sindresorhus/refined-github/blob/c7497caa5f602a8a0ec28564833611761ef00bd7/source/features/open-all-selected.js#L21-L24

Another things is that when you press shift + o they're not marked as read immediately

Can be fixed by replacing the unread class with read.

PR welcome!

vanniktech · 2018-04-24T13:49:50Z

Can be fixed by replacing the unread class with read.

Should not we just click on the Mark as read button?

vanniktech · 2018-04-25T09:06:45Z

cc @bfred-it

fregante · 2018-04-25T10:11:59Z

Each click triggers an ajax request. We should probably use classList.replace in open-all-notifications

)

Maxscores and others added 6 commits March 30, 2018 18:10

Update Manifest

271e7bc

Add require and enableFeature in content

f8fec04

Add Feature File

fe9eb87

Enable feature only on notification page

96cff50

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

Add event listener to open tab

e7edbe3

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

Add application to manifest

2a534cc

Maxscores mentioned this pull request Apr 2, 2018

Shortcut to open notification in a new tab #1110

Closed

Maxscores and others added 7 commits April 2, 2018 14:11

Fix linter issues

1d651f6

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

Merge branch 'master' of https://github.com/Maxscores/refined-github

d43fd33

Convert spaces to tabs

05fe924

Update open-notification-in-new-tab.js

e674597

ESLint Tab fix

2c40d48

Spaces > tabs

524ba78

Tabs :-(

13074dc

sindresorhus reviewed Apr 3, 2018

View reviewed changes

sindresorhus changed the title ~~Open Notification in New Tab~~ Add hotkey to open selected notification in new tab Apr 3, 2018

Update PR Review Comments

cd78c08

Co-Authored-By: Tyler Madsen <madsen.tyler@gmail.com> Co-Authored-By: Alex Barnes <abarnes26@users.noreply.github.com>

fregante assigned fregante and unassigned fregante Apr 3, 2018

fregante self-requested a review April 3, 2018 15:21

fregante added 2 commits April 3, 2018 23:15

Shorten code, open any selection

9a8605e

Update shortcut position

1d46607

fregante requested changes Apr 3, 2018

View reviewed changes

Maxscores commented Apr 3, 2018

View reviewed changes

fregante added 3 commits April 3, 2018 23:18

Use select

2f49714

Move out of ajaxedPages, rename 1/2

11d8609

Rename 2/2

b0716bf

yakov116 reviewed Apr 3, 2018

View reviewed changes

Rename 3/2

543e1b6

fregante approved these changes Apr 3, 2018

View reviewed changes

fregante added the needs readme update label Apr 3, 2018

Add gif to readme

14429fb

Extend readme description

cc83602

fregante merged commit 1e24281 into refined-github:master Apr 6, 2018

fregante removed the needs readme update label Apr 6, 2018

vanniktech mentioned this pull request Apr 24, 2018

Open selection in new [background] tab with shift+o #1284

Merged

vanniktech mentioned this pull request Apr 25, 2018

Open selection mark list item as read. #1285

Merged

dz0ny pushed a commit to dz0ny/scrum-github that referenced this pull request Oct 15, 2018

Add hotkey to open selected notification in new tab (refined-github#1240

6044707

)

yeled mentioned this pull request Nov 6, 2020

selection-in-new-tab stopped working in notifications #3704

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hotkey to open selected notification in new tab #1240

Add hotkey to open selected notification in new tab #1240

Maxscores commented Apr 2, 2018 •

edited by sindresorhus

Loading

sindresorhus Apr 3, 2018

Maxscores Apr 3, 2018

sindresorhus Apr 3, 2018

Maxscores Apr 3, 2018

sindresorhus Apr 3, 2018

Maxscores Apr 3, 2018 •

edited

Loading

fregante commented Apr 3, 2018

yakov116 commented Apr 3, 2018 •

edited

Loading

Maxscores commented Apr 3, 2018

fregante commented Apr 3, 2018 •

edited

Loading

yakov116 commented Apr 3, 2018

fregante commented Apr 3, 2018

Maxscores commented Apr 3, 2018

yakov116 commented Apr 3, 2018

fregante left a comment

Maxscores Apr 3, 2018

yakov116 left a comment

fregante commented Apr 3, 2018

Maxscores commented Apr 5, 2018

fregante commented Apr 6, 2018

vanniktech commented Apr 24, 2018 •

edited

Loading

vanniktech commented Apr 24, 2018

fregante commented Apr 24, 2018

vanniktech commented Apr 24, 2018

vanniktech commented Apr 25, 2018

fregante commented Apr 25, 2018

Add hotkey to open selected notification in new tab #1240

Add hotkey to open selected notification in new tab #1240

Conversation

Maxscores commented Apr 2, 2018 • edited by sindresorhus Loading

sindresorhus Apr 3, 2018

Choose a reason for hiding this comment

Maxscores Apr 3, 2018

Choose a reason for hiding this comment

sindresorhus Apr 3, 2018

Choose a reason for hiding this comment

Maxscores Apr 3, 2018

Choose a reason for hiding this comment

sindresorhus Apr 3, 2018

Choose a reason for hiding this comment

Maxscores Apr 3, 2018 • edited Loading

Choose a reason for hiding this comment

fregante commented Apr 3, 2018

yakov116 commented Apr 3, 2018 • edited Loading

Maxscores commented Apr 3, 2018

fregante commented Apr 3, 2018 • edited Loading

yakov116 commented Apr 3, 2018

fregante commented Apr 3, 2018

Maxscores commented Apr 3, 2018

yakov116 commented Apr 3, 2018

fregante left a comment

Choose a reason for hiding this comment

Maxscores Apr 3, 2018

Choose a reason for hiding this comment

yakov116 left a comment

Choose a reason for hiding this comment

fregante commented Apr 3, 2018

Maxscores commented Apr 5, 2018

fregante commented Apr 6, 2018

vanniktech commented Apr 24, 2018 • edited Loading

vanniktech commented Apr 24, 2018

fregante commented Apr 24, 2018

vanniktech commented Apr 24, 2018

vanniktech commented Apr 25, 2018

fregante commented Apr 25, 2018

Maxscores commented Apr 2, 2018 •

edited by sindresorhus

Loading

Maxscores Apr 3, 2018 •

edited

Loading

yakov116 commented Apr 3, 2018 •

edited

Loading

fregante commented Apr 3, 2018 •

edited

Loading

vanniktech commented Apr 24, 2018 •

edited

Loading