Update mem to fix its types

package.json

@@ -35,7 +35,7 @@
 		"intervalometer": "^1.0.5",
 		"linkify-issues": "2.0.0-nolookbehind",
 		"linkify-urls": "3.1.0-nolookbehind",
-		"mem": "^5.1.1",
+		"mem": "^6.0.1",
 		"onetime": "^5.0.0",
 		"p-filter": "^2.1.0",
 		"select-dom": "^5.1.0",

source/features/hidden-review-comments-indicator.tsx

@@ -33,9 +33,6 @@ const addIndicator = mem((commentThread: HTMLElement): void => {
 			</td>
 		</tr>
 	);
-}, {
-	// TODO [mem@>=6]: Drop argument
-	cacheKey: (element: HTMLElement) => element
 });
 
 // Add indicator when the `show-inline-notes` class is removed (i.e. the comments are hidden)

source/globals.d.ts

@@ -21,12 +21,6 @@ interface Window {
 	content: GlobalFetch;
 }
 
-// Drop after https://github.com/sindresorhus/p-memoize/issues/9
-declare module 'mem' {
-	function mem<T = VoidFunction>(fn: T, options?: AnyObject): T;
-	export = mem;
-}
-
 declare module 'size-plugin';
 
 // Custom UI events specific to RGH

source/libs/api.ts

@@ -111,6 +111,8 @@ export const v3 = mem(async (
 	}
 
 	throw await getError(apiResponse);
+}, {
+	cacheKey: JSON.stringify
 });
 
 export const v4 = mem(async (
@@ -155,6 +157,8 @@ export const v4 = mem(async (
 	}
 
 	throw await getError(apiResponse as JsonObject);
+}, {
+	cacheKey: JSON.stringify
 });
 
 async function getError(apiResponse: JsonObject): Promise<RefinedGitHubAPIError> {

source/libs/fetch-dom.ts

@@ -1,13 +1,17 @@
-import domify from 'doma';
 import mem from 'mem';
+import domify from 'doma';
 
 async function fetchDom(url: string): Promise<DocumentFragment>;
-async function fetchDom<TElement extends Element>(url: string, selector: string): Promise<TElement | null>;
+async function fetchDom<TElement extends Element>(url: string, selector: string): Promise<TElement | undefined>;
 async function fetchDom(url: string, selector?: string): Promise<Node | undefined> {
-	const urlObject = new URL(url, location.origin);
-	const response = await fetch(String(urlObject));
+	const absoluteURL = new URL(url, location.origin).toString(); // Firefox `fetch`es from the content script, so relative URLs fail
+	const response = await fetch(absoluteURL);
 	const dom = domify(await response.text());
-	return selector ? dom.querySelector(selector) || undefined : dom;
+	if (selector) {
+		return dom.querySelector(selector) || undefined;
+	}
+
+	return dom;
 }
 
 export default mem(fetchDom);