Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetOptional remove properties of types with index signatures #1013

Closed
OpportunityLiu opened this issue Dec 19, 2024 · 2 comments · Fixed by #1014
Closed

SetOptional remove properties of types with index signatures #1013

OpportunityLiu opened this issue Dec 19, 2024 · 2 comments · Fixed by #1014
Labels
bug Something isn't working

Comments

@OpportunityLiu
Copy link

OpportunityLiu commented Dec 19, 2024 •
edited by polar-sh bot
Loading

Bug description

After #1007, SetOptional remove properties of types with index signatures.

v4.30.1 works fine.

image

Repro

https://www.typescriptlang.org/play/?#code/JYWwDg9gTgLgBDAnmApnA3nAyimB5MGYCAOwEMAbOAXzgDMoIQ4ByJVAWjpQGcYWA3ACghwEjBRQ6ZAMZoAYhAgYhcNfSUAuOHyhiA5sPVwA2gA9tugwF1tAVxIBrEhADuJYdRHs0BOAF5sXAIiUkoAHkUIABpWOiUWAD4jOAB6VLgAPQB+ETV0uABRM1QZCQATbR84P0DMeIhsyxg9En04AB84B3KUOjEUcoFTCx0Wm3snF3caISA

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • The funding will be given to active contributors.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@OpportunityLiu OpportunityLiu added the bug Something isn't working label Dec 19, 2024
@svrnwnsch
Copy link

I found the same problem with setRequired as well.

@som-sm som-sm mentioned this issue Dec 19, 2024
Merged
@som-sm
Copy link
Collaborator

som-sm commented Dec 19, 2024

@OpportunityLiu / @svrnwnsch I've raised a PR to fix this issue, are there other cases that you think might cause trouble?

@vursen vursen mentioned this issue Dec 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SetOptional/SetRequired/SetReadonly: Fix instantiations with index signatures som-sm/type-fest
3 participants
@svrnwnsch @OpportunityLiu @som-sm