Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event duration #106

Open
nalves599 opened this issue Feb 25, 2024 · 0 comments
Open

Fix event duration #106

nalves599 opened this issue Feb 25, 2024 · 0 comments

Comments

@nalves599
Copy link
Contributor

nalves599 commented Feb 25, 2024

Is this change 5d8c88b right @PMax5? Wouldn't it be + 1 instead of - 1?
I think that we want to ignore the hours, and only look at the days (i.e. from the 15th to the 19th of April, it's 5 days, 19 - 15 + 1 = 5). Does it make sense?
Sorry for my mistake, since you are using the new Date(endDate - beginDate).getUTCDate() it already is 5. So you don't need to increment or decrement.

Another issue that references the event duration is this line that should use event.end instead of event.duration.

- {{english ? (event.begin | dateEn: event.duration) : (event.begin | datePt: event.duration) }}
+ {{english ? (event.begin | dateEn: event.end) : (event.begin | datePt: event.end) }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant