Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError due to trying to find max between None with non None value #19

Open
pvonglehn opened this issue Apr 16, 2023 · 0 comments · May be fixed by #20
Open

TypeError due to trying to find max between None with non None value #19

pvonglehn opened this issue Apr 16, 2023 · 0 comments · May be fixed by #20

Comments

@pvonglehn
Copy link

If a bookmark column is set the a TypeError is always thrown when running the tap.

As max_bookmark is initially set to None, when we try to see if max_bookmark needs updating by comparing it to the first value of the bookmark column a TypeError is thrown:

TypeError: '>' not supported between instances of 'int' and 'NoneType'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid trying to find max between None and non None value pvonglehn/singer-tap-template
1 participant
@pvonglehn