Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing subscription_id from schema #9

Open
huntdm07 opened this issue May 4, 2018 · 2 comments
Open

Missing subscription_id from schema #9

huntdm07 opened this issue May 4, 2018 · 2 comments

Comments

@huntdm07
Copy link

huntdm07 commented May 4, 2018

There are two foreign keys in the transactions table for a given merchant account: customer_id and subscription_id.

subscription_id is not currently present in the schema of this tap, but is essential for business logic when reconciling, for example, payment data for multiple subscriptions to a single user, or monthly payments under a single subscription.

A full schema for the transactions table is documented here.

@briansloane
Copy link
Contributor

Hey @huntdm07. Sounds like that would be a valuable addition. Can you create a PR to add that to the schema over here? https://github.com/singer-io/tap-braintree/blob/master/tap_braintree/schemas/transactions.json

@mathcoder3141
Copy link
Contributor

mathcoder3141 commented Dec 21, 2019

Hey @briansloane, I took the liberty to do this. I have a PR for this and I tested this and works! Could you apply privileges to me so I can contribute to this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants