Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Numeric Fields Processed as Text - Intentional? #117

Open
BinaryPaean opened this issue Aug 17, 2021 · 0 comments
Open

Many Numeric Fields Processed as Text - Intentional? #117

BinaryPaean opened this issue Aug 17, 2021 · 0 comments

Comments

@BinaryPaean
Copy link

I probably misunderstand something about Singer, but many numeric fields are processed as text. For example: order_adjustments.tax_amount, order_adjustments.amount, customers.total_spent. A few of these have been annotated with:

"format": "singer.decimal"

But many have not. Specifically I have noticed that customer.total_spent comes through to my PostgreSQL endpoint as a text column, which is undesirable for attempting to segment customers.

Is there a reason for these fields to be text? If I create a PR that addresses it, is it more correct to update the type to "numeric" or to update the format with "singer.decimal"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant