Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Code format error #69

Closed
sminnee opened this issue Oct 28, 2020 · 8 comments
Closed

Account Code format error #69

sminnee opened this issue Oct 28, 2020 · 8 comments

Comments

@sminnee
Copy link
Contributor

sminnee commented Oct 28, 2020

The Code field of Account has started being misinterpreted as a date.

For example:

Was: 272

Now: 0272-10-27T00:00:00.000000Z

The value is still being saved into a string field in the database, though.

@sminnee
Copy link
Contributor Author

sminnee commented Oct 28, 2020

This also affects credit_note, invoice and so essentially corrupts the data import.

@briansloane
Copy link

Our team is working on a PR to fix this here: #70

@sminnee
Copy link
Contributor Author

sminnee commented Oct 28, 2020

Thanks @briansloane!

@briansloane
Copy link

@sminnee The PR has been merged. Please try it out and see if it has resolved the issue.

@sminnee
Copy link
Contributor Author

sminnee commented Oct 30, 2020

Will do. I normally use it via StitchData; will you be pushing a 2.0.1 soon or did you want me to test first?

@sminnee
Copy link
Contributor Author

sminnee commented Oct 30, 2020

Hi there — I have confirmed that this works! 🎉

Specifically, I checked:

  • the Code field on the accounts schema
  • the JournalLines.AccountCode field on the manual_journals schema
  • the LineItems.AccountCode field on the invoices schema

I look forward to a 2.0.1 release on the StitchData servers 😄 🙏

@dmosorast
Copy link
Contributor

Looks like this has been released in 2.0.1, closing this issue.

@sminnee
Copy link
Contributor Author

sminnee commented Nov 2, 2020

Thanks, I'm doing a resync on stitchdata now; I'll raise a new ticket if I see any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants