Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] SparseNDArray/DenseNDArray create methods need to accept tile extent from PlatformConfig #2966

Open
johnkerl opened this issue Sep 6, 2024 · 0 comments
Assignees

Comments

@johnkerl
Copy link
Member

johnkerl commented Sep 6, 2024

Found while working on issue #2407 / [sc-51048].

SOMADataFrame

The SOMADataFrame create method accepts platform_config here:

create = function(
schema,
index_column_names = c("soma_joinid"),
platform_config = NULL,
internal_use_only = NULL
) {

That's passed here

dom_ext_tbl <- get_domain_and_extent_dataframe(
schema,
ind_col_names = index_column_names,
tdco = tiledb_create_options
)

and used here
ind_ext <- tdco$dim_tile(ind_col_name)

SOMASparseNDArray and SOMADenseNDArray

The SOMANDArrayBase create method accepts platform_config here:

platform_config = NULL,

That's not passed here

dom_ext_tbl <- get_domain_and_extent_array(shape)

and so here
ind_ext <- shape[ind+1]

the extent is set to shape minus one.

This isn't super-high-pri, but, it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant