Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] SOMADataFrame create needs to accept a domain argument #2967

Closed
johnkerl opened this issue Sep 6, 2024 · 0 comments · Fixed by #3032
Closed

[r] SOMADataFrame create needs to accept a domain argument #2967

johnkerl opened this issue Sep 6, 2024 · 0 comments · Fixed by #3032

Comments

@johnkerl
Copy link
Member

johnkerl commented Sep 6, 2024

Found while working on issue #2407 / [sc-51048]. See also [sc-55657].

Python

The SOMADataFrame create method accepts domain here:

  • domain: Optional[Domain] = None,
  • domain:
    An optional sequence of tuples specifying the domain of each
    index column. Each tuple should be a pair consisting of the minimum and
    maximum values storable in the index column. For example, if there is a
    single int64-valued index column, then ``domain`` might be ``[(100,
    200)]`` to indicate that values between 100 and 200, inclusive, can be
    stored in that column. If provided, this sequence must have the same
    length as ``index_column_names``, and the index-column domain will be as
    specified. If omitted entirely, or if ``None`` in a given dimension,
    the corresponding index-column domain will use the minimum and maximum
    possible values for the column's datatype. This makes a
    :class:`DataFrame` growable.

R

The SOMADataFrame create method does not accept domain here:

For this reason, here

dom_ext_tbl <- get_domain_and_extent_dataframe(
schema,
ind_col_names = index_column_names,
tdco = tiledb_create_options
)

calling here
ind_dom <- arrow_type_unsigned_range(ind_col_type) - c(0,1) ## FIXME

the domain is taken from the datatype's max range.

This is a R/Python parity issue which will become noticeable on #2407 and should be prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant