Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it also be possible to use the files from node_modules? #22

Open
karfau opened this issue Apr 28, 2022 · 1 comment
Open

Would it also be possible to use the files from node_modules? #22

karfau opened this issue Apr 28, 2022 · 1 comment

Comments

@karfau
Copy link

karfau commented Apr 28, 2022

Hey there, I'm wondering why we are downloading things from npm "again".

Especially in the case of using the usePackageJSON option, after installing the dependencies for a project, all those dependencies are already available in the local file system.

What would it take to just use those files?
Or is there a good reason not to do that?

@karfau
Copy link
Author

karfau commented Nov 6, 2022

Meanwhile we switched to copying files from node modules, which is of course way faster and more reliable.
For that we use some custom field in package.json that points to the file in the the node_modules/package folder, which we nerd to copy, since we need to pick the correct UMD build.
We also have some handling for development mode, where we copy source maps of that file if available and look for unminified/development version of a file and copy that one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant