-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] nim cpp -r torch.nim
=> nimble test
? (more standard)
#6
Comments
nim cpp -r torch.nim
=> nimble test
? (more standard)nim cpp -r torch.nim
=> nimble test
? (more standard)
@jwollen What do you think? We are hardly using nimble much lately. People is already reluctant towards nim, conda is a better ticket in. Altho yes, we could put all our tests in the nimble file on the other end. |
well tests should be in a nim file, but Here's a concrete example where this matters:
|
We added some tests in nimble file, |
@sinkingsugar after I updated to try the new this works:
this doesnt:
indeed: ls $nim_D/pytorch/build/output/share |
You need to copy some files back in the output folder in order to generate derivatives and declarations. like:
I will add it to the readme soonish |
ah ok, |
Do you think so? I'm actually curious about it.. |
I actually quite like it :) not that it can't be improved, but compared to D's dub, this was a pleasant upgrade. Are there specific bugs in https://github.com/nim-lang/nimble/issues/ you're referring to? if they're not there we should definitely add a bug report so it doesn't get lost
let files = ["torch/generator.nim", ..., "tests/test_xor.nim"]
task test_cuda, "Run cuda gpu tests":
for file in files:
exec "nim cpp -r -o:test -d:cuda " & file
exec """nim cpp -d:release -r -o:test -d:cuda torch"""
|
Nimble has a major flaw, which is it applies all the packages it has on every project you have by default. That's my major concern that easy can create a mess if not considered. Do you mind we open a issue about those points above? no time right now but they make sense :) |
=> #11
I'd like to understand what you're referring to here; when you have time, do you mind providing more details in particular what kind of mess it can create, and what you'd want it to do instead ? if not a minimal test case at least enough info :-)
|
Thank you! I will give you an example exactly with nimtorch:
|
=> moved to #12 to keep each issue separate |
No description provided.
The text was updated successfully, but these errors were encountered: