Set timeout promise support #227
Conversation
|
cc @orlangure this unblocks the "how-to guide" PR |
| @@ -568,6 +570,13 @@ function withGlobal(_global) { | |||
| delay: timeout | |||
| }); | |||
| }; | |||
| if (symbolUtilPromisifyCustom) { | |||
| clock.setTimeout[symbolUtilPromisifyCustom] = function (delay) { | |||
| return new _global.Promise(function (resolve) { | |||
There was a problem hiding this comment.
Could you store a reference to Promise at initialization time? Would help in Jest in the cases where people mess with globals
There was a problem hiding this comment.
Hmm, can you elaborate on that?
There was a problem hiding this comment.
People have tests that do
global.Promise = undefinedinside of their test. It would be great to be resilient to that by grabbing a copy of the original Promise early. Use case being to test how their code behaves without promises available
There was a problem hiding this comment.
@SimenB You're basically just saying that lolex should do something like this, right?
// needed not to break in case people null out the `Promise` property in user-code
var originalPromise = _global.Promise;And then reference that when using Promises internally.
|
Guys, any news here? |
|
@benjamingr No idea why it stalled, but regarding the point on AUTHORS, the answer is no. That is not a "No, you are not allowed to", but "No, it's pointless, as it will be overwritten by a script". |
|
I'm not sure why this stalled either, seems important. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Commenting to remove the |
| this.clock.tick(10); | ||
|
|
||
| assert(lolex.evalCalled); | ||
| assert(evalCalled); | ||
| delete global.evalFn; |
There was a problem hiding this comment.
Delete this before the assertion so that it's guaranteed to get called. If the assertion above fails, this won't be cleaned up.
|
This has been inactive for 7 months, so thought I'd try to understand what's blocking progress. Maybe we are seeing a social deadlock? 🤓 @benjamingr Are you waiting for someone to do something? Because I think this has been reviewed, everyone thinks its good, but it just needs to address a couple of very minor issues - and the failing CI build, of course. I can't see anything else blocking this, but I've been blind to the most obvious stuff before, so ... |
Yeah this is on me, I'm setting up an appointment to fix this in my next slot in my calendar so this doesn't get missed again. Sorry, it keeps slipping my mind since I never run into this issue with lolex myself. |
|
@benjamingr ping 😀 |
Purpose (TL;DR) - mandatory
Fixes #223 by supporting util.promisify on fake setTimeout
Background (Problem in detail) - optional
By the way, I started a new job at @testimio (actually doing test related stuff) - can I change the email in AUTHORS?