-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built v4.1.5 uses old version of nise #1656
Comments
Thank you for the very precise error report 👌 I've published Could you verify the fix on your end and if confirmed, close this issue? |
BackgroundThis issue was caused by an error on my part, as I forgot to run |
I have published |
Thanks for the quick reply, v4.1.6 looks fine! |
Thanks |
What did you expect to happen? / What actually happens
The build of sinon at http://sinonjs.org/releases/sinon-4.1.5.js should be built with nise v1.2.0, but is somehow being built with an earlier version of nise. The same applies to
sinon/pkg/sinon.js
when installing sinon v4.1.5 locally using npm.How to reproduce
Note that http://sinonjs.org/releases/sinon-4.1.5.js doesn't include the changes from sinonjs/nise@1990dd0#diff-8e958e497c1f86e91539a2fc732ef143 (search for
Fake server response body should be string
). Earlier versions of sinon (e.g. v4.1.4) do include the change.The text was updated successfully, but these errors were encountered: