You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it stands, it is not clear what a sigpro.SigPro object actually is from the name alone. Currently, the approach to constructing and running a pipeline is to instantiate a sigpro.SigPro object:
Following this, we can run the pipeline on sample data using the process_signal instance method, which under the hood calls the _apply_pipeline method:
However, the sigpro.SigPro constructor itself calls the _build_pipeline method to actually build the pipeline. A more intuitive interface would look like:
This new create_pipeline method should still return a SigPro pipeline (potentially not a sigpro.SigPro object), and should preserve the process_signal interface.
The text was updated successfully, but these errors were encountered:
Description
As it stands, it is not clear what a
sigpro.SigPro
object actually is from the name alone. Currently, the approach to constructing and running a pipeline is to instantiate asigpro.SigPro
object:mypipeline = sigpro.SigPro(transformations, aggregations, keep_columns = True)
Following this, we can run the pipeline on sample data using the
process_signal
instance method, which under the hood calls the_apply_pipeline
method:processed_data, feature_columns = pipeline.process_signal(dataframe, '1h', time_index = 'timestamp')
However, the
sigpro.SigPro
constructor itself calls the_build_pipeline
method to actually build the pipeline. A more intuitive interface would look like:This new
create_pipeline
method should still return a SigPro pipeline (potentially not asigpro.SigPro
object), and should preserve theprocess_signal
interface.The text was updated successfully, but these errors were encountered: