Color scheme modal should save on change (rather than on confirm)

[MaximoMachado]

Currently the onClose handle for the model calls onCancel rather than onConfirm. As a user, I found it jarring to see the color scheme I selected change suddenly when I exited because I didn't explicitly click the save button. Maybe in the future if there are more preference settings it makes sense for clicking outside the modal to be the same behavior as Cancelling but from an intuitive sense, it felt incorrect.

Now I could be wrong here so opening up this issue for discussion. I'm curious how other people feel about it and whether they feel like it makes more sense to cancel on clicking outside the modal or if it makes more sense to save on clicking outside the modal. It would be a simple change either way so mostly a design choice.

[cjquines]

i think it makes more sense to have a modal prompt for onCancel anyway i think

[psvenk]

Alternatively, we could have the modal refuse to close (but rather show some sort of animation) when clicking outside, to alert the user that they should explicitly save or cancel.

[YoVishruthK]

autosave every time a change is made