Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm start / npm build don't type check #89

Closed
psvenk opened this issue Dec 2, 2024 · 1 comment · Fixed by #96
Closed

npm start / npm build don't type check #89

psvenk opened this issue Dec 2, 2024 · 1 comment · Fixed by #96

Comments

@psvenk
Copy link
Member

psvenk commented Dec 2, 2024

It turns out that Create React App's npm start and npm build don't check if the source type checks; they just run Babel and throw an error if the input is not syntactically valid TypeScript. We should run tsc somewhere (both for these scripts and for CI) instead of just relying on editor integrations and/or manually running tsc.

@cjquines
Copy link
Member

cjquines commented Dec 8, 2024

i've basically never seen a project where the npm dev command runs typechecking or linting.

the build command i've sometimes seen runs the lint and typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants