Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

representing TLS and WSS transports in HEP #6

Open
dpocock opened this issue Oct 13, 2016 · 1 comment
Open

representing TLS and WSS transports in HEP #6

dpocock opened this issue Oct 13, 2016 · 1 comment

Comments

@dpocock
Copy link

dpocock commented Oct 13, 2016

Looking at the patch adding HEP support to FreeSWITCH, it appears TLS and WSS are not really covered:

https://freeswitch.org/fisheye/rdiff/freeswitch?csid=981b528c48a44e0e775f6c8dec8e91ce9a01f252&u&N

+   /* PROTOCOL */
+   if(strcmp(self->tp_name->tpn_proto, "tcp") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else if(strcmp(self->tp_name->tpn_proto, "tls") == 0) hg->ip_proto.data = IPPROTO_IDP; /* FAKE*/
+   else if(strcmp(self->tp_name->tpn_proto, "sctp") == 0) hg->ip_proto.data = IPPROTO_SCTP;
+   else if(strcmp(self->tp_name->tpn_proto, "ws") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else if(strcmp(self->tp_name->tpn_proto, "wss") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else hg->ip_proto.data = IPPROTO_UDP; /* DEFAULT UDP */

Is that a limitation of HEP or is the FreeSWITCH implementation simply incomplete?

@adubovikov
Copy link
Member

It was not compete, we will recheck it next week. Thank you for the pointers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants