Rename GLOBAL scopeType to prevent clash with T_GLOBAL

Author: sirbrillig

VariableAnalysis/Lib/ScopeType.php

@@ -6,6 +6,6 @@ class ScopeType {
     const PARAM = 'param';
     const BOUND = 'bound';
     const LOCAL = 'local';
-    const GLOBAL = 'global';
+    const GLOBALSCOPE = 'global';
     const STATIC = 'static';
 }

VariableAnalysis/Lib/VariableInfo.php

@@ -88,7 +88,7 @@ class VariableInfo {
     ScopeType::LOCAL  => 'variable',
     ScopeType::PARAM  => 'function parameter',
     ScopeType::STATIC => 'static variable',
-    ScopeType::GLOBAL => 'global variable',
+    ScopeType::GLOBALSCOPE => 'global variable',
     ScopeType::BOUND  => 'bound variable',
   );
 

VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

@@ -972,7 +972,7 @@ protected function processVariableAsGlobalDeclaration(File $phpcsFile, $stackPtr
     }
 
     // It's a global declaration.
-    $this->markVariableDeclaration($varName, ScopeType::GLOBAL, null, $stackPtr, $currScope);
+    $this->markVariableDeclaration($varName, ScopeType::GLOBALSCOPE, null, $stackPtr, $currScope);
     return true;
   }
 
@@ -1523,7 +1523,7 @@ protected function processScopeCloseForVariable(File $phpcsFile, VariableInfo $v
       // of "unused variable" warnings.
       return;
     }
-    if ($varInfo->scopeType === ScopeType::GLOBAL && isset($varInfo->firstInitialized)) {
+    if ($varInfo->scopeType === ScopeType::GLOBALSCOPE && isset($varInfo->firstInitialized)) {
       // If we imported this variable from the global scope, any further use of
       // the variable, including assignment, should count as "variable use" for
       // the purposes of "unused variable" warnings.